-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve diagnostic for Git fsmonitor settings in Homebrew repository: #17794
Conversation
- Added a check for the core.fsmonitor setting in the Homebrew repository - Provided an error message with instructions to disable fsmonitor if it is set to 'true' - Ensured the instructions specify making the change in the Homebrew repository folder This update helps prevent potential issues with lock files during 'brew upgrade' operations.
We already set Is this not working for you? |
@carlocab It didn't work for me. I received message from brew about another process running. I checked running process and find git fsmonitor process which hold lock file. |
What's the output of your |
|
I don't see how the instructions here do anything different to: brew/Library/Homebrew/cmd/update.sh Lines 578 to 582 in eda3039
Might be worth debugging why that's not kicking in on your system. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Unfortunately, also want to hold off on this until we figure out what's not working with the existing logic.
You right I see set fsmonitor false now. Maybe I have old version of brew or something strange happened. I will investigate issue if it will happen again. |
@carlocab I think I found the reason for the issue:
Could you apply the same thing to repositories in Taps? |
We could, though I've been under the impression that that wouldn't be needed. I wonder if we should just make sure that lock gets release (e.g. by closing file descriptor |
This update helps prevent potential issues with lock files during 'brew upgrade' operations.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?