Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Discourage the use of rm_f and rm_rf in formulae and casks #17705

Merged
merged 10 commits into from
Aug 1, 2024
Merged

rubocop: Discourage the use of rm_f and rm_rf in formulae and casks #17705

merged 10 commits into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. rubocop: Discourage the use of FileUtils.rm_rf 

    - This cop checks for the use of `FileUtils.rm_rf` and suggests using
  `FileUtils.rm_r` because we should know if we couldn't delete a
  thing for some reason, not just force it.
    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e6976ae View commit details
    Browse the repository at this point in the history

  2. rubocop/no_fileutils_rmrf: Extend to cover FileUtils#rm_f too

    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f4e4808 View commit details
    Browse the repository at this point in the history

  3. rubocop/no_fileutils_rmrf: Extend to cover FileUtils#rmtree too

    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ebd9d18 View commit details
    Browse the repository at this point in the history

  4. rubocop/no_fileutils_rmrf: Reorganize tests

    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    cc77846 View commit details
    Browse the repository at this point in the history

  5. rubocop/no_fileutils_rmrf: Discourage Pathname#rmtree too 

    - This [seems to be](https://ruby-doc.org/3.3.4/exts/pathname/Pathname.html#method-i-rmtree)
  equivalent to `FileUtils#rm_r`, so replace it with that.
    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    14dd359 View commit details
    Browse the repository at this point in the history

  6. rubocop/no_fileutils_rmrf: Scope to just formulae and casks

    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    99c5cc9 View commit details
    Browse the repository at this point in the history

  7. Casks use FileUtils.rm_rf & Pathname.rmtree still

    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0889df8 View commit details
    Browse the repository at this point in the history

  8. rubocop/no_fileutils_rmrf: Handle rmtree as an instance method

    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    83e21fb View commit details
    Browse the repository at this point in the history

  9. rubocops/no_fileutils_rmrf: Fix rmtree on a method returning Pathname 

    - Tidy up the node matchers. Either `FileUtils.rm_rf` or `rm_rf` on a
  `Pathname` instance or `self`.
    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7404735 View commit details
    Browse the repository at this point in the history

  10. Avoid double parentheses for eg. (path/here/).rmtree corrections

    @issyl0
    issyl0 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0872966 View commit details
    Browse the repository at this point in the history