Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce UnpackStrategyType #17640

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Introduce UnpackStrategyType #17640

merged 2 commits into from
Jul 8, 2024

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Jul 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@dduugg dduugg requested a review from issyl0 July 6, 2024 05:36
@dduugg dduugg marked this pull request as draft July 6, 2024 05:42
MikeMcQuaid
MikeMcQuaid reviewed Jul 6, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far here, thanks @dduugg!

Library/Homebrew/unpack_strategy.rb Show resolved Hide resolved
Library/Homebrew/unpack_strategy.rb Outdated Show resolved Hide resolved
@dduugg dduugg changed the title Introduce UnpackStrategyImpl Introduce UnpackStrategyType Jul 6, 2024
@dduugg dduugg marked this pull request as ready for review July 6, 2024 17:57
issyl0
issyl0 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand this more now I've read more things. :shipit:

@issyl0
Copy link
Member

issyl0 commented Jul 8, 2024 •
edited
Loading

Since this is merging into #17636 I'll rebase merge this in now and we can deal with the (pre-existing) failing cask tests over there.

@issyl0 issyl0 merged commit 0076a88 into sorbet-strict-public-apis Jul 8, 2024
15 of 21 checks passed
@issyl0 issyl0 deleted the pr/17636 branch July 8, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dduugg @issyl0 @MikeMcQuaid