Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: Make more files (that have public APIs defined in them) typed: strict #17636

Merged
merged 10 commits into from
Jul 12, 2024

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    bd9c777 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fdd7fdd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed4b6d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd18694 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Configuration menu
    Copy the full SHA
    0a18f77 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Introduce UnpackStrategyImpl

    dduugg authored and issyl0 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4ebf111 View commit details
    Browse the repository at this point in the history
  2. Apply suggested changes

    dduugg authored and issyl0 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0076a88 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    9c64309 View commit details
    Browse the repository at this point in the history
  2. unpack_strategy: Fix ref_type type (Symbol, not String)

    - I put a debugger call in the test that was failing.
    - Running the install command at that debug prompt and lo,
      the typing bug was staring me in the face:
    
    ```
    Error: An exception occurred within a child process:
      TypeError: Parameter 'ref_type': Expected type T.nilable(String), got type Symbol with value :branch
    Caller: /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11471/lib/types/private/methods/call_validation.rb:215
    Definition: /opt/homebrew/Library/Homebrew/unpack_strategy.rb:102 (UnpackStrategy.detect)
    ```
    issyl0 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    bffb470 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    edb8055 View commit details
    Browse the repository at this point in the history