-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share code between cask token and formula name audits. #17562
Conversation
b7a14ac
to
1f5a2c2
Compare
I think it's nicer to maintain consistency between them both, making/keeping them both stricter. |
44fd8ad
to
e2655a3
Compare
Can you clarify what you mean here? |
I'm not sure how to clarify, really! I'm just disagreeing with the sentence here that relaxing the token audit so that it's not consistent with the formula name audit seems like introducing undesirable inconsistency. |
The cask token audit is relaxed a bit while the formula name is made more strict, so the end result is they are consistent. |
Hah, ok, sorry for my misunderstanding then 👍🏻 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
e2655a3
to
77e3a40
Compare
These casks should be renamed/aliased:
|
Good to self-merge when you're happy @reitermarkus! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This relaxes the casks token audit and makes the formula name audit more strict.