Fix/reenable brew style docs
#17491
Merged
Fix/reenable brew style docs
#17491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
changed the title
brew style docs.brew style docs
- start running this check again - check the `docs` basename correctly - use a different name (to a symlink) for the docs rubocop configuration so that path relativity is done correctly: https://docs.rubocop.org/rubocop/configuration.html#path-relativity - add more wildcards to fix docs rubocop exclusions
MikeMcQuaid
force-pushed
the
brew_style_docs
branch
from
919b412
to
a707c70
Compare
ZhongRuoyu
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled to get #17482 over the line but let's fix it up now.
docsbasename correctlyconfiguration so that path relativity is done correctly:
https://docs.rubocop.org/rubocop/configuration.html#path-relativity