cask/audit: update signing checks for app, binary, and pkg #17031
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehel
changed the title
krehel
force-pushed
the
update-artifact-audit
branch
from
118e066
to
7cd11b7
Compare
MikeMcQuaid
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Great work so far, thanks @krehel!
This is still not complete, as this will still fail some valid Casks (such as GitHub Desktop)
What's the failure? A (unnotarized) binary? If so: I think we should just make that check strict only.
| when Artifact::App | ||
| system_command("spctl", args: ["--assess", "--type", "execute", path], print_stderr: false) | ||
| when Artifact::Binary | ||
| system_command("codesign", args: ["-vvvv", "-R=notarized", "--check-notarization", path], |
There was a problem hiding this comment.
I think checking for notarisation should be a separate (strict) check. My understanding is it's not required for ARM/Gatekeeper/Quarantine.
The message below can also probably remove "notarize" from it, too.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?POC changes to address some issues in auditing Casks, where we are failing some valid Casks.
This doc used as the source material for updating the checks. Based on it, the checks should be different where it is an app, a pkg, or a binary.
This is still not complete, as this will still fail some valid Casks (such as GitHub Desktop), and we need to implement (IMHO) some checking directly DMG's to check signature. But hopeful this kickstarts a conversation.