Support bash in privileged mode #16948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Mar 25, 2024
carlocab
approved these changes
Mar 26, 2024
carlocab
approved these changes
Mar 27, 2024
| @@ -44,9 +44,10 @@ _create_lock() { | |||
| [[ -x "${ruby}" ]] || ruby="$(type -P ruby)" | |||
| [[ -x "${python}" ]] || python="$(type -P python)" | |||
|
|
|||
| if [[ -x "${ruby}" ]] && "${ruby}" -e "exit(RUBY_VERSION >= '1.8.7')" | |||
| # Use /dev/stdin, otherwise Ruby can error if uid != euid. | |||
| if [[ -x "${ruby}" ]] && "${ruby}" /dev/stdin <<<"exit(RUBY_VERSION >= '1.8.7')" | |||
There was a problem hiding this comment.
Suggested change
| if [[ -x "${ruby}" ]] && "${ruby}" /dev/stdin <<<"exit(RUBY_VERSION >= '1.8.7')" | |
| if [[ -x "${ruby}" ]] && "${ruby}" - <<<"exit(RUBY_VERSION >= '1.8.7')" |
This is equivalent, no? Though I suppose /dev/stdin is more explicit.
There was a problem hiding this comment.
There was a problem hiding this comment.
I've adjusted the comment to mention that
|
Looks good, thanks @Bo98! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables "privileged" mode in bash (which despite the name doesn't necessary elevate anything). This will filter out even more environment variables. It also enables the ability for EUID to be different to UID. This is a powerful tool that can be used in certain environments to better handle cask sudo privileges and I would like to give users the option to use it.
We defer the safety of such scenarios to the user calling brew. Homebrew will check if EUID or UID is root and abort, which should prevent the most common misuse via
setuidroot executables. No further checks than that are made. The caller should assume that either the EUID or UID can be escalated to at any time.For compatibility reasons, we will only use the EUID in formula build scripts and set UID to equal that.