Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: audit redis relicense #16928

Merged
merged 2 commits into from Mar 21, 2024
Merged

formula_auditor: audit redis relicense #16928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
216c79c
formula_auditor: handle `redis` relicense
p-linnane Mar 21, 2024
df84883
formula_auditor: generalize relicensed formula audit
p-linnane Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
41 changes: 16 additions & 25 deletions Library/Homebrew/formula_auditor.rb
View file
Open in desktop
Expand Up @@ -484,35 +484,26 @@
"which allows them to use our Linux bottles, which were compiled against system glibc on CI."
end

ELASTICSEARCH_KIBANA_RELICENSED_VERSION = "7.11"

def audit_elasticsearch_kibana
return if formula.name != "elasticsearch" && formula.name != "kibana"
return unless @core_tap
return if formula.version < Version.new(ELASTICSEARCH_KIBANA_RELICENSED_VERSION)

problem "Elasticsearch and Kibana were relicensed to a non-open-source license from version 7.11. " \
"They must not be upgraded to version 7.11 or newer."
end

# https://www.hashicorp.com/license-faq#products-covered-by-bsl
HASHICORP_RELICENSED_FORMULAE_VERSIONS = {
"terraform" => "1.6",
"packer" => "1.10",
"vault" => "1.15",
"boundary" => "0.14",
"consul" => "1.17",
"nomad" => "1.7",
"waypoint" => "0.12",
"vagrant" => "2.4",
"vagrant-compleion" => "2.4",
RELICENSED_FORMULAE_VERSIONS = {
"boundary" => "0.14",
"consul" => "1.17",
"elasticsearch" => "7.11",
"kibana" => "7.11",
"nomad" => "1.7",
"packer" => "1.10",
"redis" => "7.4",
"terraform" => "1.6",
"vagrant" => "2.4",
"vagrant-completion" => "2.4",
"vault" => "1.15",
"waypoint" => "0.12",
}.freeze

def audit_hashicorp_formulae
return unless HASHICORP_RELICENSED_FORMULAE_VERSIONS.key? formula.name
def audit_relicensed_formulae
return unless RELICENSED_FORMULAE_VERSIONS.key? formula.name
return unless @core_tap

relicensed_version = Version.new(HASHICORP_RELICENSED_FORMULAE_VERSIONS[formula.name])
relicensed_version = Version.new(RELICENSED_FORMULAE_VERSIONS[formula.name])

Check warning on line 506 in Library/Homebrew/formula_auditor.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/formula_auditor.rb#L506 

Added line #L506 was not covered by tests
return if formula.version < relicensed_version

problem "#{formula.name} was relicensed to a non-open-source license from version #{relicensed_version}. " \
Expand Down