bump-*-pr: handle HOMEBREW_NO_GITHUB_API=1 being set

[gibfahn]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Commits (oldest to newest)

e11f797 bump-*-pr: handle HOMEBREW_NO_GITHUB_API=1 being set

We early return here
https://github.com/homebrew/brew/blob/92a4311868322188478d7a90511ec0e8e6b0d7df/Library/Homebrew/utils/github/api.rb#L220
, but don't then handle that through the stack.

Repro:

❯ HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_GITHUB_API=1 brew bump-formula-pr --write-only --version 1.2.3 --no-audit jq
Error: undefined method `[]' for nil:NilClass
Do not report this issue until you've run `brew update` and tried again.
Warning: Removed Sorbet lines from backtrace!
/opt/homebrew/Library/Homebrew/utils/github.rb:565:in `block in fetch_pull_requests'
/opt/homebrew/Library/Homebrew/utils/github/api.rb:334:in `paginate_graphql'
/opt/homebrew/Library/Homebrew/utils/github.rb:564:in `fetch_pull_requests'
/opt/homebrew/Library/Homebrew/utils/github.rb:628:in `check_for_duplicate_pull_requests'
/opt/homebrew/Library/Homebrew/dev-cmd/bump-formula-pr.rb:456:in `check_open_pull_requests'
/opt/homebrew/Library/Homebrew/dev-cmd/bump-formula-pr.rb:135:in `run'
/opt/homebrew/Library/Homebrew/brew.rb:89:in `<main>'
Rerun with `--verbose` to see the original backtrace

[MikeMcQuaid]

@gibfahn Can you explain the motivation for this rather than what it does?

[gibfahn]

We have automation using these commands in taps other than homebrew/core and homebrew/cask.

Also I have wanted to be able to run this locally to do version replacement without needing public internet access.

[MikeMcQuaid]

@gibfahn I still don't understand the motivation here, sorry. You have automation: why/how is that effected by the existing behaviour?

[gibfahn]

Sorry, I didn't dig into this enough. Have now used pry to do more digging, and it seems to be a missing nil check caused by HOMEBREW_NO_GITHUB_API=1 being set. We already handle it deeper in the stack, but then don't catch that properly. I updated the PR/commit message with more details.

[MikeMcQuaid]

Can this be moved to the beginning of the fetch_pull_requests method instead and check the specific variable used? Thanks!

[gibfahn]

Changed it to check the env var directly, let me know if this is what you had in mind.

[MikeMcQuaid]

Thanks again @gibfahn!

[MikeMcQuaid]

brew style --fix is required: https://github.com/Homebrew/brew/actions/runs/8417714289/job/23046704929?pr=16925