Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula Cookbook: Enrich the Service block methods section #16924

Merged

Conversation

Jerry1144
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Expand the explanation of why run is required for most fields in service do, and expand the description of name and require_root. Following #16908 and the doc change in #16914

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Jerry1144! One tiny nit.

docs/Formula-Cookbook.md Outdated Show resolved Hide resolved
@KissMyPixel

This comment was marked as off-topic.

Expand the explanation of why `run` is required for most fields in `service do`,
and expand the description of `name` and `require_root`.
@Jerry1144 Jerry1144 force-pushed the expand-services-formula-cookbook branch from 9a3fd21 to 6535fc1 Compare March 20, 2024 12:14
@MikeMcQuaid MikeMcQuaid merged commit 6efdf98 into Homebrew:master Mar 20, 2024
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @Jerry1144!

@Jerry1144 Jerry1144 deleted the expand-services-formula-cookbook branch March 25, 2024 07:40
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants