cask/artifact: check the bundle version when using --adopt.
#16889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
adopt_bundle_version
branch
2 times, most recently
from
7c88598
to
a554366
Compare
This makes `--adopt` considerably faster and more useful for application bundles by checking the bundle version before failing to adopt the bundle. This could be further extended by e.g. checking if auto-updates are enabled. While we're here, also allow `adopt` to act a bit more like `force` in a few other places assuming this initial check passes.
MikeMcQuaid
force-pushed
the
adopt_bundle_version
branch
from
a554366
to
a3702a2
Compare
SMillerDev
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
--adoptconsiderably faster and more useful for application bundles by checking the bundle version before failing to adopt the bundle.This could be further extended by e.g. checking if auto-updates are enabled.
While we're here, also allow
adoptto act a bit more likeforcein a few other places assuming this initial check passes.Can test with e.g.
brew install fork; sudo rm -rf /opt/homebrew/Caskroom/fork; brew install --adopt fork