New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cask/audit: allow @ for versioned casks #16865
Conversation
Signed-off-by: Michael Cho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
Thanks @cho-m |
Going to merge this to unblock us in migration. We can always modify audit further if needed or we find this approach isn't ideal. cc @Homebrew/cask if anyone wants to make any comments after merge, which I will follow up on. |
What should happen to casks that currently use Is |
Oh right, I missed “cask token @ unrelated to versioning …”. |
I went with the simplest option of only allowing a single One thing the audit doesn't catch is misuse of that For formulae, we check there is an unversioned formula. If this can be guaranteed for official Casks, then we can add audit. |
Thanks again @cho-m! |
I think so. There won't be an |
We do accept casks that only have unstable versions with no stable release. There may be a case for using |
Don't we use unversioned name for these and just keep the name when it becomes stable? At least according to our (soon outdated) docs: https://docs.brew.sh/Acceptable-Casks#but-there-is-no-stable-version. I think the current approach is fine to avoid extra versioned Casks. If we migrate some Casks without modifying name, e.g. |
Yes, but we just use the unversioned name in that case, since there will eventually be a stable version. |
Also, opened WIP update to audit in #16882. Although we don't need it for |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Specifically for
homebrew-cask-versions
migration intohomebrew-cask
(Homebrew/homebrew-cask#112102).Unlike Formulae, we don't need to worry about replacing
@
in token name toAT
so can handle this the easy way by just loosening audit.