Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various brew update behaviour improvements #16855

Merged
merged 1 commit into from Mar 11, 2024
Merged

Conversation

MikeMcQuaid
Copy link
Member

  • Output a message every time auto-update is run rather than a 3 second timer. This makes it more obvious that Homebrew isn't just sitting doing nothing for 2.9 seconds.
  • Output a message when running brew update so Homebrew doesn't just sit there silently doing nothing.
  • Update all taps when brew update is run, not just those hosted on GitHub. This makes it more obvious that people don't need to explictly run brew update "just in case".
  • As a result of this, remove brew tap --force-auto-update as it's no longer necessary.

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense 👍

- Output a message every time auto-update is run rather than a 3 second
  timer. This makes it more obvious that Homebrew isn't just sitting
  doing nothing for 2.9 seconds.
- Output a message when running `brew update` so Homebrew doesn't just
  sit there silently doing nothing.
- Update all taps when `brew update` is run, not just those hosted on
  GitHub. This makes it more obvious that people don't need to explictly
  run `brew update` "just in case".
- As a result of this, remove `brew tap --force-auto-update` as it's no
  longer necessary.
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks!

Comment on lines -266 to -268
# exceeds 3 seconds.
auto-update-timer() {
sleep 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a strong opinion, but feels nicer to try tweaking the 3 second timer before jumping to showing it all the time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlocab I think having it (almost) immediately print output makes the output more responsive (and, in turn, Homebrew "feel" faster).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying this out I agree that having the immediate feedback feels nicer. Otherwise I wonder whether brew has started updating, or whether it's just blocked on loading files or something.

@MikeMcQuaid MikeMcQuaid merged commit 8215f3a into master Mar 11, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the update_tweaks branch March 11, 2024 16:59
@nicolaerario
Copy link

This is a great update @MikeMcQuaid !
Why I say this?
Because many users complain about the slowness of brew and I believe that this "expedient" will change that perception: just giving an update progression notice will change that a lot. I always believed that a progression percentage would totally change the perception of brew's slowness. Thank you

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants