Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: default hash syntax. #16848

Merged
merged 2 commits into from Mar 8, 2024
Merged

rubocop: default hash syntax. #16848

merged 2 commits into from Mar 8, 2024

Conversation

MikeMcQuaid
Copy link
Member

As-of 3.1: this mean that you omit the hash value if the name is the same as the key.

We're allowing this already and it didn't make sense to land until the bulk of the other RuboCop 3.1 changes did but, now we're ready, it is more concise and a pattern that people will need to understand anyway.

@MikeMcQuaid MikeMcQuaid requested a review from a team March 7, 2024 15:45
SMillerDev
SMillerDev approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some proper magic right there

@MikeMcQuaid
rubocop: default hash syntax.
3840d71 
As-of 3.1: this mean that you omit the hash value if the name is the
same as the key.

We're allowing this already and it didn't make sense to land until the
bulk of the other RuboCop 3.1 changes did but, now we're ready, it is
more concise and a pattern that people will need to understand anyway.
@MikeMcQuaid
Copy link
Member Author

Error: You called sig twice without declaring a method in between

any idea what's going on or how to debug this @dduugg?

@dduugg
Copy link
Sponsor Member

dduugg commented Mar 7, 2024

Error: You called sig twice without declaring a method in between

any idea what's going on or how to debug this @dduugg?

This is your culprit (error message could be better): https://github.com/Homebrew/brew/pull/16848/files#diff-7f62150baa805002e8934bd1ae264d83858f2a7587d7f1db2d4f33a5bc5e57a3

@MikeMcQuaid
Copy link
Member Author

Thanks all for the catch 👁️

@MikeMcQuaid MikeMcQuaid changed the title rubocop default hash syntax rubocop: default hash syntax. Mar 7, 2024
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
access: use default hash syntax.
d4ab4d3 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
actionlint: use default hash syntax.
e0cfea0 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
ain: use default hash syntax.
b6ae1c9 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
ali: use default hash syntax.
9aa19a0 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
aliddns: use default hash syntax.
9ce7115 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
aliyun-cli: use default hash syntax.
6c27779 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
alp: use default hash syntax.
a9b53cb 
For Homebrew/brew#16848
@MikeMcQuaid MikeMcQuaid mentioned this pull request Mar 7, 2024
Merged
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
amfora: use default hash syntax.
e11afeb 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
anycable-go: use default hash syntax.
54fa18d 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
apko: use default hash syntax.
219e61a 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
arangodb: use default hash syntax.
c158f6d 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
arduino-cli: use default hash syntax.
1f9525f 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
argocd-vault-plugin: use default hash syntax.
547e45a 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
arkade: use default hash syntax.
c87a64c 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
atlas: use default hash syntax.
269eb28 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
autobrr: use default hash syntax.
c4265e9 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Mar 7, 2024
@MikeMcQuaid
aws-iam-authenticator: use default hash syntax.
c51373c 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-bundle that referenced this pull request Mar 7, 2024
@MikeMcQuaid
Use RuboCop default hash syntax.
4b91ca2 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-command-not-found that referenced this pull request Mar 7, 2024
@MikeMcQuaid
Use RuboCop default hash syntax.
59645ea 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-formula-analytics that referenced this pull request Mar 7, 2024
@MikeMcQuaid
Use RuboCop default hash syntax.
c2952ec 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-services that referenced this pull request Mar 7, 2024
@MikeMcQuaid
Use RuboCop default hash syntax.
6489329 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-test-bot that referenced this pull request Mar 7, 2024
@MikeMcQuaid
Use RuboCop default hash syntax.
def249d 
For Homebrew/brew#16848
This was referenced Mar 7, 2024
Merged
Merged
Merged
Merged
MikeMcQuaid added a commit to Homebrew/homebrew-test-bot that referenced this pull request Mar 7, 2024
@MikeMcQuaid
Use RuboCop default hash syntax.
520f9c9 
For Homebrew/brew#16848
@MikeMcQuaid MikeMcQuaid mentioned this pull request Mar 7, 2024
Merged
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
ibabel: use default hash syntax.
57f764f 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
redquits: use default hash syntax.
e0b2d2a 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
smultron: use default hash syntax.
9215fc3 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
winzip: use default hash syntax.
a2bb55a 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
cmd/lib/changed_files: use default hash syntax.
8f41fc5 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
cmd/lib/check: use default hash syntax.
dac9a34 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
cmd/lib/ci_matrix: use default hash syntax.
f38b1c9 
For Homebrew/brew#16848
MikeMcQuaid added a commit to Homebrew/homebrew-cask that referenced this pull request Mar 7, 2024
@MikeMcQuaid
cmd/lib/generate-matrix: use default hash syntax.
a149f88 
For Homebrew/brew#16848
@MikeMcQuaid MikeMcQuaid mentioned this pull request Mar 7, 2024
Merged
@MikeMcQuaid MikeMcQuaid merged commit b70884a into master Mar 8, 2024
34 checks passed
@MikeMcQuaid MikeMcQuaid deleted the rubocop_default_hash_syntax branch March 8, 2024 07:55
@apainintheneck apainintheneck mentioned this pull request Mar 9, 2024
Merged
scpeters added a commit to osrf/homebrew-simulation that referenced this pull request Mar 11, 2024
@scpeters
Fix hash syntax
ed724a4 
Follow-up to Homebrew/brew#16848.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters mentioned this pull request Mar 11, 2024
Merged
scpeters added a commit to osrf/homebrew-simulation that referenced this pull request Mar 11, 2024
@scpeters
Fix hash syntax (#2586)
98e78ab 
Follow-up to Homebrew/brew#16848.

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@reitermarkus reitermarkus reitermarkus left review comments

@SMillerDev SMillerDev SMillerDev approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MikeMcQuaid @dduugg @Bo98 @reitermarkus @SMillerDev @chenrui333 @p-linnane