dev-cmd/bump: Point out if formulae should be kept in sync with others

[issyl0]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

• Related to brew bump refuses to bump linked formulae #16383.
• This will give some information to users of brew bump that they should keep the version of the formula in sync with other formulae.
• A future enhancement is actually making the bumping of the "related" formulae automatic with --open-pr. But for now, telling people so that they don't have to wait until brew audit fails either locally or in CI at a later stage is a good start.

[issyl0]

I like the sound of consolidating the duplicated-ish code that's in FormulaAuditor#audit_synced_versions_formulae and here into somewhere new, but I can't decide on where. Any suggestions?

[MikeMcQuaid]

Looks good so far, thanks @issyl0!

[MikeMcQuaid]

• A future enhancement is actually making the bumping of the "related" formulae automatic with --open-pr. But for now, telling people so that they don't have to wait until brew audit fails either locally or in CI at a later stage is a good start.

@issyl0 Any thoughts on just jumping straight to the automatic step? Not saying you should do that instead of this PR or that it should block but just interested in your thought process here.

I like the sound of consolidating the duplicated-ish code that's in FormulaAuditor#audit_synced_versions_formulae and here into somewhere new, but I can't decide on where. Any suggestions?

I think it could live in FormulaAuditor and this call out to that class as that's what "owns" this file IMO.

[issyl0]

Any thoughts on just jumping straight to the automatic step?

I didn't have brain power to figure out how to do the automatic step when I first looked at this, but I thought that this step was a good middle ground for telling users "watch out there's more work here" that's usually hidden in the JSON file.

[MikeMcQuaid]

I didn't have brain power to figure out how to do the automatic step when I first looked at this, but I thought that this step was a good middle ground for telling users "watch out there's more work here" that's usually hidden in the JSON file.

Yeh, I'm fine with merging this as an in-between step.

My thinking is that something a brew bump invocation that doesn't include all the necessary formulae at once will fail.

I guess I ask because the code could be even simpler: something like:

• get the list of formulae you're checking for bumps
• if the list contains any synced_versions_formulae: check that it includes all the synced_versions_formulae for that formula
• if it doesn't: error out telling people which formulae need specified manually
• if it does: continue as-is

[MikeMcQuaid]

Looks good, thanks @issyl0!