Skip to content

Commit

Permalink
Merge pull request #17355 from Homebrew/dependabot/bundler/Library/Ho…
Browse files Browse the repository at this point in the history
…mebrew/rubocop-1.64.0

build(deps-dev): bump rubocop from 1.63.5 to 1.64.0 in /Library/Homebrew
  • Loading branch information
MikeMcQuaid committed May 23, 2024
2 parents 1c71732 + 6e92884 commit ff950e6
Show file tree
Hide file tree
Showing 27 changed files with 627 additions and 356 deletions.
5 changes: 5 additions & 0 deletions Library/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,11 @@ Style/RescueStandardError:
Style/ReturnNil:
Enabled: true

# Broken with rubocop-1.64.0, tries to autocorrect calls to e.g. :"1?"
# TODO: report to rubocop
Style/SendWithLiteralMethodName:
Enabled: false

# We have no use for using `warn` because we
# are calling Ruby with warnings disabled.
Style/StderrPuts:
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ GEM
rspec-support (3.13.1)
rspec_junit_formatter (0.6.0)
rspec-core (>= 2, < 4, != 2.12.0)
rubocop (1.63.5)
rubocop (1.64.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/artifact/abstract_uninstall.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def self.from_args(cask, **directives)
def initialize(cask, **directives)
directives.assert_valid_keys(*ORDERED_DIRECTIVES)

super(cask, **directives)
super
directives[:signal] = Array(directives[:signal]).flatten.each_slice(2).to_a
@directives = directives

Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/artifact/binary.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module Artifact
# Artifact corresponding to the `binary` stanza.
class Binary < Symlinked
def link(command: nil, **options)
super(command:, **options)
super
return if source.executable?

if source.writable?
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/artifact/installer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def self.from_args(cask, **args)
attr_reader :path, :args

def initialize(cask, **args)
super(cask, **args)
super

if args.key?(:manual)
@path = Pathname(args[:manual])
Expand Down
4 changes: 2 additions & 2 deletions Library/Homebrew/cask/artifact/keyboard_layout.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ module Artifact
# Artifact corresponding to the `keyboard_layout` stanza.
class KeyboardLayout < Moved
def install_phase(**options)
super(**options)
super
delete_keyboard_layout_cache(**options)
end

def uninstall_phase(**options)
super(**options)
super
delete_keyboard_layout_cache(**options)
end

Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/artifact/mdimporter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def self.english_name
end

def install_phase(**options)
super(**options)
super
reload_spotlight(**options)
end

Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/artifact/pkg.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def self.from_args(cask, path, **stanza_options)
end

def initialize(cask, path, **stanza_options)
super(cask, path, **stanza_options)
super
@path = cask.staged_path.join(path)
@stanza_options = stanza_options
end
Expand Down
4 changes: 2 additions & 2 deletions Library/Homebrew/cask/artifact/qlplugin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ def self.english_name
end

def install_phase(**options)
super(**options)
super
reload_quicklook(**options)
end

def uninstall_phase(**options)
super(**options)
super
reload_quicklook(**options)
end

Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/artifact/relocated.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def resolve_target(target, base_dir: config.public_send(self.class.dirmethod))
.void
}
def initialize(cask, source, **target_hash)
super(cask, source, **target_hash)
super

target = target_hash[:target]
@source_string = source.to_s
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/dsl/caveats.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Caveats < Base
attr_predicate :discontinued?

def initialize(*args)
super(*args)
super
@built_in_caveats = {}
@custom_caveats = []
@discontinued = false
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cli/args.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Args < OpenStruct
def initialize
require "cli/named_args"

super()
super

@processed_options = []
@options_only = []
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/dependency.rb
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def hash

sig { params(minimum_version: T.nilable(Version), minimum_revision: T.nilable(Integer)).returns(T::Boolean) }
def installed?(minimum_version: nil, minimum_revision: nil)
use_macos_install? || super(minimum_version:, minimum_revision:)
use_macos_install? || super
end

sig { returns(T::Boolean) }
Expand Down
8 changes: 4 additions & 4 deletions Library/Homebrew/download_strategy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,11 @@ def basename
private

def puts(*args)
super(*args) unless quiet?
super unless quiet?
end

def ohai(*args)
super(*args) unless quiet?
super unless quiet?
end

def silent_command(*args, **options)
Expand Down Expand Up @@ -605,7 +605,7 @@ def curl_output(*args, **options)
raise HomebrewCurlDownloadStrategyError, url unless Formula["curl"].any_version_installed?

options[:use_homebrew_curl] = true
super(*args, **options)
super
end
end

Expand All @@ -620,7 +620,7 @@ def initialize(url, name, version, **meta)
# GitHub Packages authorization header.
# HOMEBREW_GITHUB_PACKAGES_AUTH set in brew.sh
meta[:headers] << "Authorization: #{HOMEBREW_GITHUB_PACKAGES_AUTH}"
super(url, name, version, **meta)
super
end

private
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/extend/ENV/std.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def determine_cxx

sig { void }
def clang
super()
super
replace_in_cflags(/-Xarch_#{Hardware::CPU.arch_32_bit} (-march=\S*)/, '\1')
map = Hardware::CPU.optimization_flags.dup
if DevelopmentTools.clang_build_version < 700
Expand Down
4 changes: 2 additions & 2 deletions Library/Homebrew/install_renamed.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ def cp_path_sub(pattern, replacement)
end

def +(other)
super(other).extend(InstallRenamed)
super.extend(InstallRenamed)
end

def /(other)
super(other).extend(InstallRenamed)
super.extend(InstallRenamed)
end

private
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/manpages/converter/kramdown.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def convert_a(element, options)
# Don't duplicate the URL if the link text is the same as the URL.
"<#{text}>"
else
super(element, options)
super
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/requirements/arch_requirement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ArchRequirement < Requirement

def initialize(tags)
@arch = tags.shift
super(tags)
super
end

satisfy(build_env: false) do
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/requirements/codesign_requirement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def initialize(tags)
@identity = options.fetch(:identity)
@with = options.fetch(:with, "code signing")
@url = options.fetch(:url, nil)
super(tags)
super
end

satisfy(build_env: false) do
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/requirements/macos_requirement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def message(type: :formula)
end

def ==(other)
super(other) && comparator == other.comparator && version == other.version
super && comparator == other.comparator && version == other.version
end
alias eql? ==

Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/requirements/xcode_requirement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class XcodeRequirement < Requirement

def initialize(tags = [])
@version = tags.shift if tags.first.to_s.match?(/(\d\.)+\d/)
super(tags)
super
end

sig { returns(T::Boolean) }
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/resource.rb
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def files(*files)
def fetch(verify_download_integrity: true)
fetch_patches

super(verify_download_integrity:)
super
end

# {Livecheck} can be used to check for newer versions of the software.
Expand Down
Loading

0 comments on commit ff950e6

Please sign in to comment.