unpack_strategy/*: Convert to Sorbet typed: strict

Homebrew · Jul 12, 2024 · edb8055 · edb8055
1 parent bffb470
commit edb8055
Show file tree

Hide file tree

Showing 33 changed files with 92 additions and 47 deletions.
diff --git a/Library/Homebrew/unpack_strategy/air.rb b/Library/Homebrew/unpack_strategy/air.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,13 +11,15 @@ def self.extensions
  [".air"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  mime_type = "application/vnd.adobe.air-application-installer-package+zip"
  path.magic_number.match?(/.{59}#{Regexp.escape(mime_type)}/)
  end
 
+ sig { returns(T.nilable(T::Array[Cask::Cask])) }
  def dependencies
- @dependencies ||= [Cask::CaskLoader.load("adobe-air")]
+ @dependencies ||= T.let([Cask::CaskLoader.load("adobe-air")], T.nilable(T::Array[Cask::Cask]))
  end
 
  AIR_APPLICATION_INSTALLER =

diff --git a/Library/Homebrew/unpack_strategy/bazaar.rb b/Library/Homebrew/unpack_strategy/bazaar.rb
@@ -1,13 +1,14 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "directory"
 
 module UnpackStrategy
  # Strategy for unpacking Bazaar archives.
  class Bazaar < Directory
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
- super && (path/".bzr").directory?
+ !!(super && (path/".bzr").directory?)
  end
 
  private

diff --git a/Library/Homebrew/unpack_strategy/bzip2.rb b/Library/Homebrew/unpack_strategy/bzip2.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,6 +11,7 @@ def self.extensions
  [".bz2"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\ABZh/n)
  end

diff --git a/Library/Homebrew/unpack_strategy/cab.rb b/Library/Homebrew/unpack_strategy/cab.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,6 +11,7 @@ def self.extensions
  [".cab"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\AMSCF/n)
  end
@@ -23,8 +24,9 @@ def extract_to_dir(unpack_dir, basename:, verbose:)
  verbose:
  end
 
+ sig { returns(T.nilable(T::Array[Formula])) }
  def dependencies
- @dependencies ||= [Formula["cabextract"]]
+ @dependencies ||= T.let([Formula["cabextract"]], T.nilable(T::Array[Formula]))
  end
  end
 end
diff --git a/Library/Homebrew/unpack_strategy/compress.rb b/Library/Homebrew/unpack_strategy/compress.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "tar"
@@ -11,6 +11,7 @@ def self.extensions
  [".Z"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\A\037\235/n)
  end

diff --git a/Library/Homebrew/unpack_strategy/cvs.rb b/Library/Homebrew/unpack_strategy/cvs.rb
@@ -1,13 +1,14 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "directory"
 
 module UnpackStrategy
  # Strategy for unpacking CVS repositories.
  class Cvs < Directory
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
- super && (path/"CVS").directory?
+ !!(super && (path/"CVS").directory?)
  end
  end
 end
diff --git a/Library/Homebrew/unpack_strategy/directory.rb b/Library/Homebrew/unpack_strategy/directory.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,6 +11,7 @@ def self.extensions
  []
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.directory?
  end

diff --git a/Library/Homebrew/unpack_strategy/executable.rb b/Library/Homebrew/unpack_strategy/executable.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "uncompressed"
@@ -11,6 +11,7 @@ def self.extensions
  [".sh", ".bash"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\A#!\s*\S+/n) ||
  path.magic_number.match?(/\AMZ/n)

diff --git a/Library/Homebrew/unpack_strategy/fossil.rb b/Library/Homebrew/unpack_strategy/fossil.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require "system_command"
@@ -14,6 +14,7 @@ def self.extensions
  []
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  return false unless path.magic_number.match?(/\ASQLite format 3\000/n)
 

diff --git a/Library/Homebrew/unpack_strategy/generic_unar.rb b/Library/Homebrew/unpack_strategy/generic_unar.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,12 +11,14 @@ def self.extensions
  []
  end
 
+ sig { override.params(_path: Pathname).returns(T::Boolean) }
  def self.can_extract?(_path)
  false
  end
 
+ sig { returns(T.nilable(T::Array[Formula])) }
  def dependencies
- @dependencies ||= [Formula["unar"]]
+ @dependencies ||= T.let([Formula["unar"]], T.nilable(T::Array[Formula]))
  end
 
  private

diff --git a/Library/Homebrew/unpack_strategy/git.rb b/Library/Homebrew/unpack_strategy/git.rb
@@ -1,13 +1,14 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "directory"
 
 module UnpackStrategy
  # Strategy for unpacking Git repositories.
  class Git < Directory
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
- super && (path/".git").directory?
+ !!(super && (path/".git").directory?)
  end
  end
 end
diff --git a/Library/Homebrew/unpack_strategy/gzip.rb b/Library/Homebrew/unpack_strategy/gzip.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,6 +11,7 @@ def self.extensions
  [".gz"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\A\037\213/n)
  end

diff --git a/Library/Homebrew/unpack_strategy/jar.rb b/Library/Homebrew/unpack_strategy/jar.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "uncompressed"
@@ -11,6 +11,7 @@ def self.extensions
  [".apk", ".jar"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  return false unless Zip.can_extract?(path)
 

diff --git a/Library/Homebrew/unpack_strategy/lha.rb b/Library/Homebrew/unpack_strategy/lha.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,12 +11,14 @@ def self.extensions
  [".lha", ".lzh"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\A..-(lh0|lh1|lz4|lz5|lzs|lh\\40|lhd|lh2|lh3|lh4|lh5)-/n)
  end
 
+ sig { returns(T.nilable(T::Array[Formula])) }
  def dependencies
- @dependencies ||= [Formula["lha"]]
+ @dependencies ||= T.let([Formula["lha"]], T.nilable(T::Array[Formula]))
  end
 
  private

diff --git a/Library/Homebrew/unpack_strategy/lua_rock.rb b/Library/Homebrew/unpack_strategy/lua_rock.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "uncompressed"
@@ -11,6 +11,7 @@ def self.extensions
  [".rock"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  return false unless Zip.can_extract?(path)
 

diff --git a/Library/Homebrew/unpack_strategy/lzip.rb b/Library/Homebrew/unpack_strategy/lzip.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,12 +11,14 @@ def self.extensions
  [".lz"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\ALZIP/n)
  end
 
+ sig { returns(T.nilable(T::Array[Formula])) }
  def dependencies
- @dependencies ||= [Formula["lzip"]]
+ @dependencies ||= T.let([Formula["lzip"]], T.nilable(T::Array[Formula]))
  end
 
  private

diff --git a/Library/Homebrew/unpack_strategy/lzma.rb b/Library/Homebrew/unpack_strategy/lzma.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,12 +11,14 @@ def self.extensions
  [".lzma"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\A\]\000\000\200\000/n)
  end
 
+ sig { returns(T.nilable(T::Array[Formula])) }
  def dependencies
- @dependencies ||= [Formula["xz"]]
+ @dependencies ||= T.let([Formula["xz"]], T.nilable(T::Array[Formula]))
  end
 
  private

diff --git a/Library/Homebrew/unpack_strategy/mercurial.rb b/Library/Homebrew/unpack_strategy/mercurial.rb
@@ -1,17 +1,19 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "directory"
 
 module UnpackStrategy
  # Strategy for unpacking Mercurial repositories.
  class Mercurial < Directory
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
- super && (path/".hg").directory?
+ !!(super && (path/".hg").directory?)
  end
 
  private
 
+ sig { override.params(unpack_dir: Pathname, basename: Pathname, verbose: T::Boolean).void }
  def extract_to_dir(unpack_dir, basename:, verbose:)
  system_command! "hg",
  args: ["--cwd", path, "archive", "--subrepos", "-y", "-t", "files", unpack_dir],

diff --git a/Library/Homebrew/unpack_strategy/microsoft_office_xml.rb b/Library/Homebrew/unpack_strategy/microsoft_office_xml.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "uncompressed"
@@ -15,6 +15,7 @@ def self.extensions
  ]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  return false unless Zip.can_extract?(path)
 

diff --git a/Library/Homebrew/unpack_strategy/otf.rb b/Library/Homebrew/unpack_strategy/otf.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "uncompressed"
@@ -11,6 +11,7 @@ def self.extensions
  [".otf"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\AOTTO/n)
  end

diff --git a/Library/Homebrew/unpack_strategy/p7zip.rb b/Library/Homebrew/unpack_strategy/p7zip.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,12 +11,14 @@ def self.extensions
  [".7z"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.magic_number.match?(/\A7z\xBC\xAF\x27\x1C/n)
  end
 
+ sig { returns(T.nilable(T::Array[Formula])) }
  def dependencies
- @dependencies ||= [Formula["p7zip"]]
+ @dependencies ||= T.let([Formula["p7zip"]], T.nilable(T::Array[Formula]))
  end
 
  private

diff --git a/Library/Homebrew/unpack_strategy/pax.rb b/Library/Homebrew/unpack_strategy/pax.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module UnpackStrategy
@@ -11,6 +11,7 @@ def self.extensions
  [".pax"]
  end
 
+ sig { override.params(_path: Pathname).returns(T::Boolean) }
  def self.can_extract?(_path)
  false
  end

diff --git a/Library/Homebrew/unpack_strategy/pkg.rb b/Library/Homebrew/unpack_strategy/pkg.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "uncompressed"
@@ -11,6 +11,7 @@ def self.extensions
  [".pkg", ".mkpg"]
  end
 
+ sig { override.params(path: Pathname).returns(T::Boolean) }
  def self.can_extract?(path)
  path.extname.match?(/\A.m?pkg\Z/) &&
  (path.directory? || path.magic_number.match?(/\Axar!/n))