Merge pull request #17030 from Homebrew/strict-parser

Enable strict typing in `CLI::Parser`

Library/Homebrew/abstract_command.rb

@@ -26,6 +26,9 @@ def command_name = Utils.underscore(T.must(name).split("::").fetch(-1)).tr("_",
  sig { params(name: String).returns(T.nilable(T.class_of(AbstractCommand))) }
  def command(name) = subclasses.find { _1.command_name == name }
 
+ sig { returns(T::Boolean) }
+ def dev_cmd? = T.must(name).start_with?("Homebrew::DevCmd")
+
  sig { returns(CLI::Parser) }
  def parser = CLI::Parser.new(self, &@parser_block)
 

Library/Homebrew/brew.rb

@@ -136,17 +136,17 @@
  end
 rescue UsageError => e
  require "help"
- Homebrew::Help.help cmd, remaining_args: args.remaining, usage_error: e.message
+ Homebrew::Help.help cmd, remaining_args: args&.remaining, usage_error: e.message
 rescue SystemExit => e
- onoe "Kernel.exit" if args.debug? && !e.success?
+ onoe "Kernel.exit" if args&.debug? && !e.success?
  $stderr.puts Utils::Backtrace.clean(e) if args&.debug? || ARGV.include?("--debug")
  raise
 rescue Interrupt
  $stderr.puts # seemingly a newline is typical
  exit 130
 rescue BuildError => e
  Utils::Analytics.report_build_error(e)
- e.dump(verbose: args&.verbose?)
+ e.dump(verbose: args&.verbose? || false)
 
  if OS.unsupported_configuration?
  $stderr.puts "#{Tty.bold}Do not report this issue: you are running in an unsupported configuration.#{Tty.reset}"

Library/Homebrew/cli/args.rbi

@@ -14,6 +14,9 @@ class Homebrew::CLI::Args
  sig { returns(T::Boolean) }
  def quiet?; end
 
+ sig { returns(T::Array[String]) }
+ def remaining; end
+
  sig { returns(T::Boolean) }
  def verbose?; end
 end