Merge pull request #16914 from Homebrew/service_require_root_no_run

rubocops/service: allow require_root to be used without run.
Homebrew · Mar 20, 2024 · 91d670c · 91d670c
2 parents f99c9c7 + 8ba257b
commit 91d670c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Library/Homebrew/rubocops/service.rb b/Library/Homebrew/rubocops/service.rb
@@ -37,7 +37,7 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node)
  offending_node(service_node)
  problem "Service blocks require `run` or `name` to be defined."
  elsif !method_calls.key?(:run)
- other_method_calls = method_calls.keys - [:name]
+ other_method_calls = method_calls.keys - [:name, :require_root]
  if other_method_calls.any?
  offending_node(service_node)
  problem "`run` must be defined to use methods other than `name` like #{other_method_calls}."

diff --git a/docs/Formula-Cookbook.md b/docs/Formula-Cookbook.md
@@ -970,7 +970,7 @@ end
 
 #### Service block methods
 
-This table lists the options you can set within a `service` block. The `run` or `name` field must be defined inside the service block. The `run` field indicates what command to run and is required before using fields other than `name`.
+This table lists the options you can set within a `service` block. The `run` or `name` field must be defined inside the service block. The `run` field indicates what command to run and is required before using fields other than `name` and `require_root`.
 
 | method | default | macOS | Linux | description |
 | ----------------------- | ------------ | :---: | :---: | ----------- |