Skip to content

Commit

Permalink
Merge pull request #17759 from Homebrew/revert-17719-sandbox_process_…
Browse files Browse the repository at this point in the history
…signals
  • Loading branch information
Rylan12 committed Jul 15, 2024
2 parents 8f86319 + 7d16fd9 commit 3db7d01
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 19 deletions.
1 change: 0 additions & 1 deletion Library/Homebrew/sandbox.rb
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ class SandboxProfile
(literal "/bin/ps")
(with no-sandbox)
) ; allow certain processes running without sandbox
(deny signal (target others)) ; deny sending signals to other processes
(allow default) ; allow everything else
ERB

Expand Down
18 changes: 0 additions & 18 deletions Library/Homebrew/test/sandbox_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -129,22 +129,4 @@ def initialize(*, **)
end
end
end

describe "disallow sending signal to other processes" do
# we have to spawn a process, otherwise kill doesn't try to send a signal if the process doesn't exist
let(:pid) do
pid = spawn("sleep 1000")
sleep 0.1 # Ensure the process has started
pid
end

after do
Process.kill("KILL", pid)
Process.wait(pid)
end

it "sandbox stops signal to other processes" do
expect { sandbox.exec "kill", "-SIGTERM", pid.to_s }.to raise_error(ErrorDuringExecution)
end
end
end

0 comments on commit 3db7d01

Please sign in to comment.