Avoid double parentheses for eg. (path/here/).rmtree corrections

Homebrew · Jul 25, 2024 · 25f8a84 · 25f8a84
1 parent 429028c
commit 25f8a84
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Library/Homebrew/rubocops/no_fileutils_rmrf.rb b/Library/Homebrew/rubocops/no_fileutils_rmrf.rb
@@ -46,8 +46,8 @@ def on_send(node)
  else
  node.arguments.first.source
  end
-
- corrector.replace(node.loc.expression, "#{class_name}#{new_method}(#{args})")
+ args = "(#{args})" unless args.start_with?("(")
+ corrector.replace(node.loc.expression, "#{class_name}#{new_method}#{args}")
  end
  end
 

diff --git a/Library/Homebrew/test/rubocops/no_fileutils_rmrf_spec.rb b/Library/Homebrew/test/rubocops/no_fileutils_rmrf_spec.rb
@@ -64,6 +64,8 @@ def buildpath
  end
  buildpath.rmtree
  ^^^^^^^^^^^^^^^^ Homebrew/NoFileutilsRmrf: #{RuboCop::Cop::Homebrew::NoFileutilsRmrf::MSG}
+ (path/"here").rmtree
+ ^^^^^^^^^^^^^^^^^^^^ Homebrew/NoFileutilsRmrf: #{RuboCop::Cop::Homebrew::NoFileutilsRmrf::MSG}
  RUBY
  end
 
@@ -76,6 +78,7 @@ def buildpath
  Pathname("path/to/yet/another/directory")
  end
  buildpath.rmtree
+ (path/"here").rmtree
  RUBY
 
  expect(corrected).to eq(<<~RUBY)
@@ -86,6 +89,7 @@ def buildpath
  Pathname("path/to/yet/another/directory")
  end
  FileUtils.rm_r(buildpath)
+ FileUtils.rm_r(path/"here")
  RUBY
  end
  end