Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-commit-and-push: add action #577

Merged
merged 1 commit into from
Sep 9, 2024
Merged

api-commit-and-push: add action #577

merged 1 commit into from
Sep 9, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 18, 2024

An action that take commits and pushes changes via the GitHub API rather than the git CLI.

Why? GitHub Apps need to use the API in order to sign commits. You cannot add a commit signing key to a GitHub app.

Using this also reduces the number of secrets required. Instead of a token + a GPG passphrase, you now only need a token.

See the README for example usage paired with actions/create-github-app-token@v1.

Will be used for Homebrew/brew#17294.

p-linnane
p-linnane previously approved these changes Aug 18, 2024
MikeMcQuaid
MikeMcQuaid previously approved these changes Aug 19, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @Bo98!

carlocab
carlocab previously approved these changes Sep 8, 2024
@carlocab
Copy link
Member

carlocab commented Sep 8, 2024

Does GPG commit signing work here?

@Bo98
Copy link
Member Author

Bo98 commented Sep 8, 2024

It will commit sign, but the existing setup-commit-signing action isn't supported for configuring that. This replaces both that plus git push - GitHub API will automatically sign the commit using the GitHub key.

@Bo98 Bo98 dismissed stale reviews from carlocab, MikeMcQuaid, and p-linnane via ced192b September 9, 2024 03:15
@Bo98 Bo98 merged commit e7417aa into master Sep 9, 2024
3 checks passed
@Bo98 Bo98 deleted the api-commit-and-push branch September 9, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants