Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup some unused files #2260

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

cleanup some unused files #2260

wants to merge 25 commits into from

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Mar 18, 2025

In this PR we cleanup some unused files. Many of these stem from historic build processes which are no longer relevant.

Alizter added 6 commits March 18, 2025 20:34
We don't use this script to update TOCs in STYLE.md any longer. The
current method is to use the vscode extension detailed there or manually
update it.

Signed-off-by: Ali Caglayan <[email protected]>
We no longer vendor Coq as a submodule and build it locally. We haven't
done this for a long time in fact. We cleanup this unused script.

Signed-off-by: Ali Caglayan <[email protected]>
This doesn't appear to be used anywhere.

Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
@jdchristensen
Copy link
Collaborator

Thanks, it good to get rid of out-of-date stuff. We have a lot of it...

Here are a few things I noticed that look that might be unused or need updating.

References to doctoc:

etc/ci/install_doctoc.sh
sudo -E npm install -g doctoc || exit $?

etc/ci/before_script.sh
    ./install_doctoc.sh || exit $?

STYLE.md
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
<!-- *generated with [DocToc](https://github.com/thlorenz/doctoc)* -->
<!-- END doctoc generated TOC please keep comment here to allow auto update -->

Other things in etc/ci/before_script.sh might be out of date too.

This should be removed:

Makefile.coq.local
#       $(SHOW)'HOQTHMDEP HoTT'

Alizter added 19 commits March 18, 2025 21:22
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
@Alizter
Copy link
Collaborator Author

Alizter commented Mar 18, 2025

@jdchristensen From what I can tell, none of the scripts in etc/ci are being used. They are from the Travis CI days. I've removed all of them. I've also done the other suggestions you had.

@jdchristensen
Copy link
Collaborator

Were the whitespace changes to STYLE.md intentional? I doubt they affect the output, but we try to avoid unrelated whitespace changes.

Other than that, this LGTM. It's still a draft, so I'm not sure if you have more planned.

@Alizter
Copy link
Collaborator Author

Alizter commented Mar 19, 2025

They were not intentional, I will fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants