Skip to content

building timing reports with dune #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

building timing reports with dune #2234

wants to merge 6 commits into from

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Feb 25, 2025 •
edited
Loading

This PR adds support for building timing-html files as mentioned in #2230.

TODO

  • Also put .timing files somewhere, for now only .timing.html is built
  • Generate report of slowest lines
  • Generate comparison report from last report

@Alizter
dune: enable directory targets
8c4f071 
Signed-off-by: Ali Caglayan <[email protected]>
@Alizter
make _CoqProject script sturdier
9b01706 
This substitutes the working directory instead of hard coding it like
before. This means that dune will use `_build/default` when used
normally, and the script can be run in a sandboxed action in
`_build/.sandbox/HASH/...`.

Signed-off-by: Ali Caglayan <[email protected]>
@Alizter
generate timing-html with dune
c50bbe4 
Signed-off-by: Ali Caglayan <[email protected]>
@Alizter Alizter changed the title dune: enable directory targets building timing reports with dune Feb 25, 2025
@jdchristensen
Copy link
Collaborator

This looks like a nice idea.

@Alizter
Copy link
Collaborator Author

Alizter commented Mar 18, 2025

I've added a way for dune to generate the .timing files. I'll need to now work out a way to compile this into a report about slowest lines.

Alizter added 2 commits March 19, 2025 13:10
@Alizter
tweak deps
80d5540 
Signed-off-by: Ali Caglayan <[email protected]>
@Alizter
generate preliminary timing report
61f9523 
Signed-off-by: Ali Caglayan <[email protected]>
@Alizter
Copy link
Collaborator Author

Alizter commented Mar 19, 2025

I've added a way of generating a report in _build/default/timing_report.txt. It uses the find script for combing through the .timing files. We can probably do something far more clever here.

The generated .timing files should also allow us to compare with a previous commit. I'm not sure what the best way to do this comparison is just yet. Hopefully I can draw some inspiration from the coq-tools timing scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alizter @jdchristensen