Skip to content

update alectryon #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged

update alectryon #1842

merged 1 commit into from
Feb 12, 2024

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Feb 12, 2024

No description provided.

@jdchristensen
Copy link
Collaborator

@JasonGross

 File "/github/workspace/etc/alectryon/alectryon/cli.py", line 419, in <lambda>
    write_output(ext, contents, fname, fpath, output, output_directory, coq_args_Q, coq_args_R, strip_re=strip_re)
...
TypeError: write_output() got multiple values for argument 'strip_re'

@JasonGross
Copy link
Contributor

@JasonGross

 File "/github/workspace/etc/alectryon/alectryon/cli.py", line 419, in <lambda>
    write_output(ext, contents, fname, fpath, output, output_directory, coq_args_Q, coq_args_R, strip_re=strip_re)
...
TypeError: write_output() got multiple values for argument 'strip_re'

Thanks, fixed this one, restarted job

@jdchristensen
Copy link
Collaborator

It said that there were no artifacts, so I tried restarting all jobs.

@jdchristensen
Copy link
Collaborator

@JasonGross Still getting a similar error.

Signed-off-by: Ali Caglayan <[email protected]>
@Alizter Alizter force-pushed the ps/branch/update_alectryon branch from 3d4e035 to a5fbfcb Compare February 12, 2024 21:05
@Alizter
Copy link
Collaborator Author

Alizter commented Feb 12, 2024

@jdchristensen I needed to update the submodule again to the updated version of Jason's branch. Let's see if this works.

The reason is that the actual submodule object that git is tracking is tied to the specific commit hash, so updating the branch upstream won't affect the submodule and you have to manually bump it to the later version.

Copy link
Contributor

@JasonGross JasonGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes!

@Alizter Alizter merged commit 0b9458a into HoTT:master Feb 12, 2024
@Alizter Alizter deleted the ps/branch/update_alectryon branch February 12, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants