Add Experimental GUI Tool for Quick XRT Data Preview #345
Conversation
joyvelasquez
added
enhancement
|
So the title of the PR and the description implies that this is a test and not something that will be merged into XRTPy. Is that the case or is the goal of this pull request to add a basic MPL GUI to the XRTPy code base? While I am not a maintainer of XRTPy, I do have major misgivings at merging over 1500 lines of Python code which are not tested in any meaningful way. I strongly suggest that this becomes a separate package and not add more work for the sole maintainer of XRTPy. |
|
Hi @nabobalis , thank you for taking the time to review and raise these important points. You’re absolutely right—the current version of the PR reflects work that is still in progress. @ntrueba is implementing new functionality that isn’t directly part of the core XRTpy software, but is related to XRT and potentially useful alongside XRTpy. This is also part of his process in getting more familiar with GitHub for the first time and understanding broader software development workflows. We’re planning to meet this week to discuss next steps, including how to properly test, document, and determine the best path for integration—whether as part of XRTpy or as a standalone package. We really appreciate your feedback and suggestions. We'll take them into account as we finalize the direction for this work. |
joyvelasquez
changed the title
|
|
||
| #hdul2.writeto(filen,overwrite=overwrite) | ||
|
|
||
| def date_to_meta(xrt_download_list): |
There was a problem hiding this comment.
| def date_to_meta(xrt_download_list): | |
| def _date_to_meta(xrt_download_list): |
If there's a function that is not intended for end users, then we can start the name with an underscore to indicate that it is private.
This PR introduces a new extension to XRTpy that provides an experimental graphical interface ("Gooey") for quickly previewing and accessing XRT observations.
While this code is not directly part of the core XRTpy package at this stage, it aligns well with XRT data analysis workflows and could serve as a lightweight tool for users to rapidly view available observations without downloading and manually inspecting each file.
The current implementation is a work in progress and not yet fully tested. We're exploring the best path forward, including whether this should remain a standalone utility or eventually integrate into XRTpy more formally.