Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add new buttons to filter out the internships on the basis of selected role and industry #478

Closed
wants to merge 0 commits into from

Conversation

nikki-05
Copy link
Contributor

Fixing issue #418
Filter Button for Role and Industry: Added a filter button to the InternPage component, enabling users to filter internships based on the selected role and industry from dropdown menus.

-Role-Based Filtering: Users can select a role from a dropdown menu. Clicking the filter button updates the displayed list of internships to show only those matching the chosen role.
-Industry-Based Filtering: Users can select an industry from another dropdown menu. The filter button updates the list of internships to reflect the chosen industry.
-Default Internships: If the filter button is clicked without selecting a specific role or industry, the component displays a default set of internships, ensuring that users always see some results.
Here is the video demonstration
Untitled video - Made with Clipchamp

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
career-zunction ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:58am
career-zunction-intern-testing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:58am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@nikki-05
Copy link
Contributor Author

Hello @HimanshuNarware May you review my PR and guide if any changes are needed

@PSS2134
Copy link
Contributor

PSS2134 commented Jul 27, 2024

Hi, @nikki-05
Here are some issues

  1. I cant see the details of internship in the card on filtering
  2. Initially show all the internships as its not showing any till we dont choose from select option
  3. Also dont put a filter button there, it should get filtered by just selecting from the options
  4. Use purple color for border which matches the website theme

Also use the main branch of repo for reference

@nikki-05 nikki-05 closed this Jul 28, 2024
PSS2134 added a commit that referenced this pull request Aug 4, 2024
…the basis of role and industry (#514)

Issue Fixes #478 

Added the new filter for sorting out the internships based on Role and
Industry
-Made changes in the DataBase.json file according to the filters
-Updated the CSS portion to make filters according to the layout and
style of the website
-Updated according to the earlier reviewed changes

Features:
-The filter shows default internships even without selecting any filter
-It filters out the internships when any role/ industry is selected 
-the style of the filter matches with the page 
Here is the attached image below :
![Screenshot 2024-08-01
163438](https://github.com/user-attachments/assets/47fd0b5e-34a2-4afe-8048-4a425a334f6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants