Task/rdmp 271 Update catalogue overview #2107
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk/RDMP-271-fix-catalogue-overview
…sk/RDMP-271-fix-catalogue-overview
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private List<CatalogueItem> _dateColumns; | ||
| private static readonly string[] frequencies = new[] { "Day", "Month", "Year" }; | ||
|
|
||
| private AreaChartUI areaChartUI; |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
| lblLastDataLoad.Text = latestDataLoad ?? "No Successful Data Loads"; | ||
| var extraction = _overview.GetLatestExtraction(); | ||
| lblLatestExtraction.Text = extraction ?? "Catalogue has not been extracted"; | ||
| lblRecords.Text = $"{_overview.GetNumberOfRecords().ToString()} Records"; |
Check notice
Code scanning / CodeQL
Redundant ToString() call Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Summarise your proposed changes here, including any notes for reviewers.
Type of change
What types of changes does your code introduce? Tick all that apply.
Checklist
By opening this PR, I confirm that I have: