Use convert_bool consistently, use relative Python imports, fix SSO groups #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
changed the title
AaronJackson
approved these changes
Jun 28, 2023
| @@ -81,13 +81,15 @@ def update_request(arguments: str, context: Any): | |||
|
|
|||
| # TO-DO: Inject Environment variables for reviewer group names | |||
There was a problem hiding this comment.
I might have missed something but presumably the group names are stored somewhere configurable? If so, this todo doesn't make sense anymore?
There was a problem hiding this comment.
I'd assume not..... I've created an issue and will come back to it later
#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves convert_bool to a seperate file so it can be used in multiple places, standardises on relative Python imports
Fixes SSO group check- Cognito may add a federated user to a default group, but the code only checks the first group in the returned list.
In theory this means we could pass the list of group memberships from KeyCloak to Cognito instead of adding the user to the relevant Cognito group after they've logged in the first time. In practice we'd need to work out how to pass the list of group memberships from KeyCloak to Cognito....
Declaration : By submitting this pull request, I confirm that my
contribution is made under the terms of the Apache-2.0 license