Automatically run pre-commit in GitHub workflow for pushes and pull requests #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see the full list of failures (before any fixes, and including the commented out hooks) from a previous run https://github.com/HicResearch/TREEHOOSE/runs/6487622324?check_suite_focus=true |
manics
force-pushed
the
github-precommit
branch
3 times, most recently
from
5800a9c to
dcbdbb1
Compare
|
You'll need to explain this a bit more to me. I see there's four failed checks. Is this what you're trying to fix here or something else? |
|
@drchriscole mostly looks a bit WIP to me but waiting for a review from karan. The pre-commit action failed due to a linting issue with the markdown which will get fixed in another pr. The workspace-backup failed due to the issue described in #77 |
manics
changed the title
manics
changed the title
|
This PR should contain only reformatting. Best reviewed with white-space ignored: |
AaronJackson
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've commented out themarkdownlintandcfn-python-linthooks since they require fixes (the other hooks support automatic formatting), and I'm having trouble installingmarkdownlintdue to the Ruby requirements- is using prettier an option?I've replaced markdownlint with prettier. This PR should only contain formatting changes.
I've commented out the pre-commit commit config that requires further work, either in terms of additional dependencies (#77) or minor code refactoring (flake8 fixes), I'll deal with these in a future PR.
Closes #57
Declaration : By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license