Used enum numbers in favour of magic numbers

HeyPouya · Sep 28, 2024 · 29d45fe · 29d45fe
1 parent 79c23e0
commit 29d45fe
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 31 deletions.
diff --git a/core/src/main/java/com/pouyaheydari/calendar/core/pojo/GregorianMonths.kt b/core/src/main/java/com/pouyaheydari/calendar/core/pojo/GregorianMonths.kt
@@ -18,18 +18,18 @@ enum class GregorianMonths(val monthNumber: Int) {
  December(12);
 
  fun getName(context: Context): String = when (monthNumber) {
- 1 -> context.getString(R.string.january)
- 2 -> context.getString(R.string.february)
- 3 -> context.getString(R.string.march)
- 4 -> context.getString(R.string.april)
- 5 -> context.getString(R.string.may)
- 6 -> context.getString(R.string.jun)
- 7 -> context.getString(R.string.july)
- 8 -> context.getString(R.string.august)
- 9 -> context.getString(R.string.september)
- 10 -> context.getString(R.string.october)
- 11 -> context.getString(R.string.november)
- 12 -> context.getString(R.string.december)
+ January.monthNumber -> context.getString(R.string.january)
+ February.monthNumber -> context.getString(R.string.february)
+ March.monthNumber -> context.getString(R.string.march)
+ April.monthNumber -> context.getString(R.string.april)
+ May.monthNumber -> context.getString(R.string.may)
+ Jun.monthNumber -> context.getString(R.string.jun)
+ July.monthNumber -> context.getString(R.string.july)
+ August.monthNumber -> context.getString(R.string.august)
+ September.monthNumber -> context.getString(R.string.september)
+ October.monthNumber -> context.getString(R.string.october)
+ November.monthNumber -> context.getString(R.string.november)
+ December.monthNumber -> context.getString(R.string.december)
  else -> throw IllegalArgumentException("Month number is grater than 12")
  }
 }
diff --git a/core/src/main/java/com/pouyaheydari/calendar/core/pojo/ShamsiMonths.kt b/core/src/main/java/com/pouyaheydari/calendar/core/pojo/ShamsiMonths.kt
@@ -18,18 +18,18 @@ enum class ShamsiMonths(val monthNumber: Int) {
  Esfand(12);
 
  fun getName(context: Context): String = when (monthNumber) {
- 1 -> context.getString(R.string.farvardin)
- 2 -> context.getString(R.string.ordibehesht)
- 3 -> context.getString(R.string.khordad)
- 4 -> context.getString(R.string.tir)
- 5 -> context.getString(R.string.mordad)
- 6 -> context.getString(R.string.shahrivar)
- 7 -> context.getString(R.string.mehr)
- 8 -> context.getString(R.string.aban)
- 9 -> context.getString(R.string.azar)
- 10 -> context.getString(R.string.dey)
- 11 -> context.getString(R.string.bahman)
- 12 -> context.getString(R.string.esfand)
+ Farwarding.monthNumber -> context.getString(R.string.farvardin)
+ Ordibehesht.monthNumber -> context.getString(R.string.ordibehesht)
+ Khordad.monthNumber -> context.getString(R.string.khordad)
+ Tir.monthNumber -> context.getString(R.string.tir)
+ Mordad.monthNumber -> context.getString(R.string.mordad)
+ Shahrivar.monthNumber -> context.getString(R.string.shahrivar)
+ Mehr.monthNumber -> context.getString(R.string.mehr)
+ Aban.monthNumber -> context.getString(R.string.aban)
+ Azar.monthNumber -> context.getString(R.string.azar)
+ Dey.monthNumber -> context.getString(R.string.dey)
+ Bahman.monthNumber -> context.getString(R.string.bahman)
+ Esfand.monthNumber -> context.getString(R.string.esfand)
  else -> throw IllegalArgumentException("Month number is grater than 12: $this")
  }
 }
diff --git a/core/src/main/java/com/pouyaheydari/calendar/core/pojo/WeekDay.kt b/core/src/main/java/com/pouyaheydari/calendar/core/pojo/WeekDay.kt
@@ -13,13 +13,13 @@ enum class WeekDay(val weekDayNumber: Int, val distanceFromFirstDayOfWeek: Int)
  Sunday(6, 1);
 
  fun getName(context: Context): String = when (weekDayNumber) {
- 0 -> context.getString(R.string.monday)
- 1 -> context.getString(R.string.tuesday)
- 2 -> context.getString(R.string.wednesdays)
- 3 -> context.getString(R.string.thursday)
- 4 -> context.getString(R.string.friday)
- 5 -> context.getString(R.string.saturday)
- 6 -> context.getString(R.string.sunday)
+ Monday.weekDayNumber -> context.getString(R.string.monday)
+ Tuesday.weekDayNumber -> context.getString(R.string.tuesday)
+ Wednesday.weekDayNumber -> context.getString(R.string.wednesdays)
+ Thursday.weekDayNumber -> context.getString(R.string.thursday)
+ Friday.weekDayNumber -> context.getString(R.string.friday)
+ Saturday.weekDayNumber -> context.getString(R.string.saturday)
+ Sunday.weekDayNumber -> context.getString(R.string.sunday)
  else -> throw IllegalArgumentException("Week day number is grater than 6: $this")
  }
 }