Wasm integration #47
Open
Wasm integration #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RijulTP
reviewed
May 24, 2024
| @@ -16,11 +16,11 @@ jobs: | |||
| - name: Install dependencies | |||
| run: go mod tidy | |||
| - name: Build | |||
| run: go build -v ./... | |||
| run: go build -tags=cli -v ./... | |||
There was a problem hiding this comment.
Is this done only for ones with tag cli, are there any other tags
There was a problem hiding this comment.
yes there is wasm tag also currently build is failing , checking that now
RijulTP
reviewed
May 24, 2024
Comment on lines
+58
to
+59
| keyValuePair := fmt.Sprintf("%s=%s", key, val.Data().(string)) | ||
| command = append(command, keyValuePair) |
RijulTP
reviewed
May 24, 2024
| // TODO - replace stuff in headers, and varjson and json as well | ||
| cmd, stdinBody := cmdgen.ConstructCommand(block) | ||
| resp, e1 := cmdexec.ExecCommand(cmd, stdinBody) | ||
| printFields(resp) |
RijulTP
reviewed
May 24, 2024
Comment on lines
+24
to
+26
| js.Global().Set("lama2Wasm", js.FuncOf(lama2Wasm)) | ||
| js.Global().Set("goWebRequestFunc", wasmLamaPromise()) | ||
| select {} |
There was a problem hiding this comment.
Can add a comment on what these lines do
RijulTP
reviewed
May 24, 2024
|
|
||
| func lama2Wasm(this js.Value, i []js.Value) interface{} { | ||
| go func() { | ||
| controller.ProcessWasmInput("GET\nhttps://httpbin.org/get") |
There was a problem hiding this comment.
Is this for processing the Default request?
There was a problem hiding this comment.
That function was for testing purpose , removed
RijulTP
reviewed
May 24, 2024
| @@ -6,7 +6,7 @@ import ( | |||
|
|
|||
| "github.com/HexmosTech/lama2/l2lsp/request" | |||
| "github.com/HexmosTech/lama2/l2lsp/response" | |||
| "github.com/rs/zerolog/log" | |||
| // "github.com/rs/zerolog/log" | |||
RijulTP
reviewed
May 24, 2024
|
|
||
| func ExpandHeaders(block *gabs.Container) { | ||
| headerMap := block.S("details", "headers") | ||
| // log.Info().Str("HeaderMap", headerMap.String()).Msg("") |
RijulTP
reviewed
May 24, 2024
| @@ -0,0 +1,220 @@ | |||
| //go:build wasm | |||
There was a problem hiding this comment.
What is the basic difference in the code between preprocess.wasm.go and preprocess.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of MR is this? (check all applicable)
Web assembly integration for Lama2.
Modifying Golang to add support for building web assembly binary.
Important files to start review from
Controller.wasm.go
l2.wasm.go
lama2cmd/lama2cmd.wasm.go
preprocess/preprocess.wasm.go
Build command for normal cli builds
go build -tags=cli -o build/l2 -ldflags "-X main.version=$(git tag --sort=-version:refname | head -n 1) -X main.lamawasm=cli " l2.goBuild command for wasm builds
GOOS=js GOARCH=wasm go build -o build/l2.wasm -tags=wasm -ldflags "-X main.version=$(git tag --sort=-version:refname | head -n 1) -X main.lamawasm=lamawasm " l2.wasm.go