Wasm integration by rogueloop · Pull Request #47 · HexmosTech/Lama2

rogueloop · 2024-05-11T05:49:57Z

What type of MR is this? (check all applicable)

[ x] 🍕 Feature

Web assembly integration for Lama2.

Modifying Golang to add support for building web assembly binary.

Important files to start review from in the order

other major changes :

makefile

# Build command for normal cli builds
go build -tags=cli -o build/l2 -ldflags "-X main.version=$(git tag --sort=-version:refname | head -n 1) -X main.lamawasm=cli " l2.go

# Build command for wasm builds
GOOS=js GOARCH=wasm go build -o build/l2.wasm -tags=wasm -ldflags "-X main.version=$(git tag --sort=-version:refname | head -n 1) -X main.lamawasm=lamawasm " l2.wasm.go

RijulTP · 2024-05-24T15:30:08Z

.github/workflows/testapp.yml

        run: go mod tidy
      - name: Build
-        run: go build -v ./...
+        run: go build -tags=cli -v ./...


Is this done only for ones with tag cli, are there any other tags

yes there is wasm tag also currently build is failing , checking that now

RijulTP · 2024-05-24T15:31:37Z

cmdgen/cmdgen.go

+			keyValuePair := fmt.Sprintf("%s=%s", key, val.Data().(string))
+			command = append(command, keyValuePair)


Are these changes tested?

RijulTP · 2024-05-24T15:37:50Z

controller/controller.wasm.go

+	// TODO - replace stuff in headers, and varjson and json as well
+	cmd, stdinBody := cmdgen.ConstructCommand(block)
+	resp, e1 := cmdexec.ExecCommand(cmd, stdinBody)
+	printFields(resp)


What does this do

Added it for debugging purpose, printing the response

RijulTP · 2024-05-24T15:40:52Z

l2.wasm.go

+	js.Global().Set("lama2Wasm", js.FuncOf(lama2Wasm))
+	js.Global().Set("goWebRequestFunc", wasmLamaPromise())
+	select {}


Can add a comment on what these lines do

RijulTP · 2024-05-24T15:41:16Z

l2.wasm.go

+
+func lama2Wasm(this js.Value, i []js.Value) interface{} {
+	go func() {
+		controller.ProcessWasmInput("GET\nhttps://httpbin.org/get")


Is this for processing the Default request?

That function was for testing purpose , removed

RijulTP · 2024-05-24T15:45:20Z

l2lsp/methods/lsp_lifecycle.go

 	"github.com/HexmosTech/lama2/l2lsp/request"
 	"github.com/HexmosTech/lama2/l2lsp/response"
-	"github.com/rs/zerolog/log"
+	// "github.com/rs/zerolog/log"


This can be removed right

this is for logging purpose

RijulTP · 2024-05-24T15:51:37Z

preprocess/preprocess.wasm.go

+
+func ExpandHeaders(block *gabs.Container) {
+	headerMap := block.S("details", "headers")
+	// log.Info().Str("HeaderMap", headerMap.String()).Msg("")


Can remove commented code

RijulTP · 2024-05-24T15:55:14Z

preprocess/preprocess.wasm.go

@@ -0,0 +1,220 @@
+//go:build wasm


What is the basic difference in the code between preprocess.wasm.go and preprocess.go

there is a lot of code repetition there converted it into 3 separate file to remove duplication

The difference is in function calls , wasm has 1 parameter , cli has 2 params , each of them calls different functions

Sreedeep-rougeloop and others added 22 commits October 17, 2023 19:35

working wasm implementation

aae8c2d

fixing the promise

7a60260

got the result back to web from wasm

0afffff

promise return working

8d61989

bug fix

2d1e752

widget basic working design

888cb6a

removing goja dependancy

67787e2

removing goja dependancy

17b350b

removing zerolog completely

5470ef5

Removed net http dependancy

4bc3708

proxy chenges

1894b80

addings an common wokspace

4a40c6d

Fixed proxy url

19d3e4c

removing some useles code

8d25a15

Different files for wasm and cli build

2f68122

Removing comments conveting to wasm build files

4e20d80

Add cleaning the commnets

6df60ba

cleaning code

ef7305e

removing zerolog comments

5e645f0

fixing workflow

9886c29

fixing workflow

703c800

Removing zerolog

61cb447

RijulTP reviewed May 24, 2024

View reviewed changes

RijulTP and others added 29 commits August 3, 2024 11:32

Removing goja dependency for wasm

e6ec4bc

Adding webworkers

a84f7e3

fixing the datastructure build issue

a7e344e

Merge branch 'Wasm' of github.com:HexmosTech/Lama2 into Wasm

6d04379

fixed play button

02a12fa

fixed code convertion using browser js interpreter

f8f95f5

Fixing deadlock issue

782c193

Fixed sync issue in expand var webworkers

e99b903

Fixed result variable issue in chain request

9673ba3

Renamed webworker file

3c0ae3f

Fixed cli build issue

98953f7

Added seperator

7ab6474

Merge branch 'Wasm' of github.com:HexmosTech/Lama2 into Wasm

30e22e3

Removed unwanted code

bf4e836

Issue: Heap overflow

f7d6312

Merge branch 'Wasm' of github.com:HexmosTech/Lama2 into Wasm

dcc4bd4

added inlining to silence heap failing

4a22fad

Removed httpsnippet log

df60536

Fixed build issues

69693ce

Embedded workerjs file

704ce78

Added correction to pyhon and js single stage code convert

e54872d

Added support for php

5dd3417

Updated httpsnippet

4a79319

Updated httpiego

fffc451

Added new httpe vesion

e741821

pulled changes

c457908

fixing merge conflicts

3e92c17

Merge remote-tracking branch 'origin/main' into Wasm

8a1625d

fixing the mkdocs build

4ebde26

rogueloop merged commit 73ceef1 into main Sep 1, 2024

		keyValuePair := fmt.Sprintf("%s=%s", key, val.Data().(string))
		command = append(command, keyValuePair)

Conversation

rogueloop commented May 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of MR is this? (check all applicable)

Web assembly integration for Lama2.

Important files to start review from in the order

other major changes :

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rogueloop commented May 11, 2024 •

edited

Loading