Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve interval handling when startAt set in the past #248

Merged
merged 2 commits into from
May 12, 2024
Merged

Resolve interval handling when startAt set in the past #248

merged 2 commits into from
May 12, 2024

Conversation

buzzinJohnnyBoi
Copy link
Contributor

I updated the /src/croner.js _next function to calculate when the previous run time would be when the prev (previous run) is undefined and startAt and interval are set.
I also added 1 test to the /src/suites/options.cjs for this use case.
I then ran npm run build to update the dist.
Multiple packages in the package-lock.json were also updated as a result of running npm run build

Fixes #247

Copy link
Owner

@Hexagon Hexagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hexagon Hexagon changed the base branch from master to dev May 12, 2024 00:02
@Hexagon
Copy link
Owner

Hexagon commented May 12, 2024

Thanks! Merging this into dev for inclusion in the next release

@Hexagon Hexagon merged commit e4b53cb into Hexagon:dev May 12, 2024
21 checks passed
buzzinJohnnyBoi added a commit to buzzinJohnnyBoi/croner that referenced this pull request May 18, 2024
@Hexagon Hexagon mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] interval setting does seem to ignore startAt
2 participants