Skip to content

[DX] Test that the empty library and settings page renders correctly for all languages #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Mar 16, 2025

After the issue we had in the 2.16.0 release I think it's a good idea to add this test to make sure the empty library and the settings can be accessed for all languages. It should help catch broken translations.

I'll try to find a way to test the library with content too since that's also a valid initial state, but that will be another PR cause I don't think we have a way to do that currently in tests.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 16, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team March 16, 2025 22:38
@arielj arielj marked this pull request as ready for review March 16, 2025 22:38
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@arielj arielj force-pushed the test-empty-library-languages branch from 38a2f6f to 5e4ba8b Compare May 19, 2025 22:52
@arielj arielj merged commit ec9f4dd into main May 19, 2025
9 checks passed
@arielj arielj deleted the test-empty-library-languages branch May 19, 2025 23:13
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants