-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Warn when Shader Pre-Cache is disabled and using umu in SD's gaming mode #4328
base: main
Are you sure you want to change the base?
Conversation
I dug through the original issue on gamescope's GitHub and it seems that this has been fixed in UMU already. Probably should double check though |
The umu FAQ says it's needed, and this is a message from last week saying it's a hard requirement, not something that can be fixed by umu Open-Wine-Components/umu-launcher#92 (comment) |
Hmm I guess GE was referring to some other issue being fixed with python-xlib then ? |
it doesn't seem to be a gamescope issue either? umu needs the steam app id to properly handle the screens changing, and it gets the id from those env variables the issue seems to be that the only way to get those env variables to be populated is with the Shader Pre-Caching enabled I understand the issue would be solved if the SteamOS or its variants would just add an ENV variable or a simpler way to just get the steam app id directly without unrelated env variables parsing EDIT: also, I can confirm the issue, I tested it too when it was discussed in a Discord thread, you disable Shader Pre-Caching and then games stops working with umu in gaming mode (well, the game works, but the steam loading screen is not removed, the game works in the background) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adds new information in the logs to help both users and support, this is more important now that we are going to default to umu and we already recommend umu to users over discord.
When using umu on the SteamDeck's gaming mode, it looks for the
steam app id
in different environment variables that are only defined when the Steam'sShader Pre-Cache
is enabled.When all those conditions are met, the logs will now include a warning message to instruct the users that this is not enabled and the game may not work properly.
More details: https://github.com/Open-Wine-Components/umu-launcher/wiki/Frequently-asked-questions-(FAQ)#why-am-i-not-able-to-see-my-game-when-using-my-launcher-from-steam-mode-gaming-mode
Use the following Checklist if you have changed something on the Backend or Frontend: