improve batch insert

[chitalian]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
helicone	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 19, 2025 6:36pm
helicone-bifrost	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 19, 2025 6:36pm
helicone-eu	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 19, 2025 6:36pm

[promptless]

✅ No documentation updates required.

[greptile-apps]

PR Summary

Enhanced batch insert functionality for improved database performance in input record creation and experiment management.

• Added createInputRecords method in /valhalla/jawn/src/managers/inputs/InputsManager.ts for efficient bulk insertion using a single SQL query
• Optimized /valhalla/jawn/src/managers/experiment/ExperimentV2Manager.ts to use batch operations instead of individual Promise.all calls
• Implemented UUID generation and parameterized values for secure batch processing
• Added organization-level validation checks for prompt versions in batch operations

_{2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: returning inputRecordIds without verifying successful insertion of all records. Should compare result.data.length with inputs.length

Suggested change

	return ok(inputRecordIds);
	if (result.data?.length !== inputs.length) {
	return err('Not all records were inserted successfully');
	}
	return ok(inputRecordIds);

[fumedev]

Summary

• Improved batch insertion of input records in ExperimentV2Manager by replacing a loop with a single method call to InputsManager.createInputRecords.
• Added the createInputRecords method in InputsManager, which dynamically constructs and executes a batch INSERT SQL query.
• The new method includes validation to ensure the prompt version exists before proceeding with the insert.
• Utilizes UUIDs for identifying each input record, improving uniqueness and traceability.

⏳ 5 tests in progress