ECP-2415 -- add extra details to charge request #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remik
requested changes
Jun 19, 2024
aa_stripe/models.py
Outdated
| @@ -409,8 +409,15 @@ def charge(self, idempotency_key=None): | |||
| metadata = { | |||
| "object_id": self.object_id, | |||
| "content_type_id": self.content_type_id, | |||
| "member_uuid": str(self.user.uuid), | |||
There was a problem hiding this comment.
This lib is public and some other users might not have this field
Suggested change
| "member_uuid": str(self.user.uuid), | |
| "member_uuid": str(self.user.uuid) if hasattr(self.user, "uuid") else None, |
There was a problem hiding this comment.
made the updates
aa_stripe/models.py
Outdated
| @@ -409,8 +409,15 @@ def charge(self, idempotency_key=None): | |||
| metadata = { | |||
| "object_id": self.object_id, | |||
| "content_type_id": self.content_type_id, | |||
| "member_uuid": str(self.user.uuid), | |||
| "origin": "roman_api", | |||
There was a problem hiding this comment.
Please move it to some settings.
remik
previously approved these changes
Jun 21, 2024
|
@remik i updated release details and version. if you can review |
remik
approved these changes
Jun 25, 2024
|
Looks good. Let me know if you have access with releasing it. If not I can add you to pypi or just release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT: