Use "--use-feature=2020-resolver" to fix #390 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 88 88
Lines 4585 4585
Branches 855 855
=======================================
Hits 3936 3936
Misses 464 464
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The GitHub Actions job on the master branch still complains about incompatibility among dependencies.
https://github.com/HazyResearch/fonduer/runs/1103656295?check_suite_focus=true With this PR, the dependencies are nicely resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problems or issues
Is your pull request related to a problem? Please describe.
See #390.
Does your pull request fix any issue.
Fix #390.
Description of the proposed changes
Use
--use-feature=2020-resolveroption along withpip install.This option is currently "robust beta" and will become the default resolver as of 20.3, slated to be released on October, 2020 (see here).
We could wait for 20.3, but I'd like to start testing this.
If something does not work for us, we could report an issue to the pip community before it is released.
Test plan
Manually check if dependencies are correctly resolved.
Checklist