Skip to content

Fix unit test Makefile bugs for A100 and 4090 results in linker failure due to cuda libraries missing #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomflinda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix unit test Makefile bugs for A100 and 4090 results in linker failure due to cuda libraries missing #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ endif

# Compiler flags based on GPU target
ifeq ($(GPU_TARGET),4090)
NVCCFLAGS+= -arch=sm_89 -DKITTENS_4090
NVCCFLAGS+= -arch=sm_89 -DKITTENS_4090 -lcuda -lcudart
else ifeq ($(GPU_TARGET),A100)
NVCCFLAGS+= -arch=sm_80 -DKITTENS_A100
NVCCFLAGS+= -arch=sm_80 -DKITTENS_A100 -lcuda -lcudart
else ifeq ($(GPU_TARGET),H100)
NVCCFLAGS+= -arch=sm_90a -DKITTENS_HOPPER -lcuda -lcudart
endif
Expand Down