-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds option to run configuration to expand macros in environment variables #3872
adds option to run configuration to expand macros in environment variables #3872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, great work!
It works well for me, just a few minor things.
This will definitely require some documentation. This macro replacement using the default macros is something I haven't completely figured out yet. Take for example the ContentRoot macro, when you put the caret in a LaTeX file and compile then it is fine, but if you put it somewhere else like the pdf file or the project tool window then this macro does not work for me (is replaced by the empty string). This might not be easy to fix, if not we should document this.
src/nl/hannahsten/texifyidea/run/latex/ui/LatexSettingsEditor.kt
Outdated
Show resolved
Hide resolved
src/nl/hannahsten/texifyidea/run/latex/ui/LatexSettingsEditor.kt
Outdated
Show resolved
Hide resolved
…d file (CommonDataKeys.VIRTUAL_FILE) by the .tex file targetted in the RunConfiguration during macro expansion
I'll follow up with a suggestion for the documentation. I have now, in the latest version, changed the
|
src/nl/hannahsten/texifyidea/run/latex/CustomContextProgramParametersConfigurator.kt
Fixed
Show fixed
Hide fixed
src/nl/hannahsten/texifyidea/run/latex/CustomContextProgramParametersConfigurator.kt
Fixed
Show fixed
Hide fixed
…nagerImpl#withEnvironmentDataContext instead
…ndMacrosEnvVariables is true
Added a documentation section in 9a31277. Please let me know if there's any change you'd like to see there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, works great! Thanks for adding the documentation.
Fix #3867
Summary of additions and changes
How to test this pull request
Set
TEXINPUTS
to a value containing a macro. Run the following with LuaLaTeX to print the value of saidTEXINPUTS
:Alternatively, one can also include a file that isn't findable, and add the directory containing said file to
TEXINPUTS
through a macro to verify it works correctly.Documentation section added in 9a31277
I don't know what a test would look like, but again: if one is necessary, I'd be happy to implement it, having been provided more details about what it would look like.