Skip to content

eventtap: setProperty choose CGEventField setter based on value type #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mogenson wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

eventtap: setProperty choose CGEventField setter based on value type #3859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions extensions/eventtap/libeventtap_event.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,7 @@ static int eventtap_event_getButtonState(lua_State* L) {
///
/// Notes:
/// * The properties are `CGEventField` values, as documented at https://developer.apple.com/library/mac/documentation/Carbon/Reference/QuartzEventServicesRef/index.html#//apple_ref/c/tdef/CGEventField
/// * Integer values use `CGEventSetIntegerValueField` and number values use `CGEventSetDoubleValueField`.
static int eventtap_event_setProperty(lua_State* L) {
CGEventRef event = *(CGEventRef*)luaL_checkudata(L, 1, EVENT_USERDATA_TAG);
CGEventField field = (CGEventField)(luaL_checkinteger(L, 2));
Expand All @@ -820,9 +821,14 @@ static int eventtap_event_setProperty(lua_State* L) {
(field == kCGTabletEventTangentialPressure)) {
double value = luaL_checknumber(L, 3) ;
CGEventSetDoubleValueField(event, field, value);
} else {
int64_t value = (int64_t)luaL_checkinteger(L, 3);
} else if (lua_isinteger(L, 3)) {
int64_t value = (int64_t)lua_tointeger(L, 3);
CGEventSetIntegerValueField(event, field, value);
} else if (lua_isnumber(L, 3)) {
double value = lua_tonumber(L, 3) ;
CGEventSetDoubleValueField(event, field, value);
} else {
[LuaSkin logError:@"hs.eventtap.event:setProperty() - Invalid value type."];
}

lua_settop(L,1) ;
Expand Down
Loading