-
Notifications
You must be signed in to change notification settings - Fork 626
Miscellaneous updates to enable compilation #3785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Fixed Jog Wheel LED caching. - Fixed crashed in authentication timer. - Improved documentation. - Added better error handling to `:getDevice()`. - Added example to documentation. - Simplified the `:jogMode()` method.
Speed Editor Support
- CommandPost now actually builds with the correct build number! Woohoo!
Allow notarization of different files.
- The only thing I really did was remove `CocoaAsyncSocket` from `F53OSC`, and Xcode did the rest.
This reverts commit 6dfca23.
- For some reason the Stream Deck Mini Button 1 triggers an `eventType` of `0x01` (instead of `0x00`) on button press (but not release). - Closes Hammerspoon#3432
to silence C++ errors from stricter compiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']
@latenitefilms @cmsj No worries. I don't understand but it looks like your commits are in my branch in my repo as well. I created a new branch which has my original commits, in case anyone wants to follow up on making use of them: https://github.com/algal/hammerspoon/commits/dev-compile_fixes2 |
These are changes I made only in order to get the HEAD of master to compile. I believe they are behaviorally neutral, but I have not tested them in any depth.
But the app compiles and runs on my system (macOS 15.5 24F74, Xcode 16.4, brew/libgccjit 15.1.0, brew/gcc 15.10).
These are the changes:
-Wno-missing-include-dirs
to silence a breaking warning for the targetnoises
osascript
, fixed a format specifierstream deck
, refactored to an NS_ENUM and add a default switch case.razer
, fixed a format specifierscreen
, fixed format specifiersmidi
, added crashing asserts for previously unhandled switch cases, for unknownMIKMIDICommandType
. This is one of the potentially dangerous changes, if code is accidentally relying on the non-existing default behavior now. Commit 2a571c5hid
, fixed format specifiershid
, add crashing asserts for previously unhandled switch case, for unknown op codes toaccess_capslock
. Commit f982bb8.As you can see, most of this is super boring and obvious.
The two risky commits are the ones which introduce asserts which will crash in case a switch gets a value which it now has no default handling for. I looked at these briefly and it seems fine. But it might deserve a glance from someone who knows that code, or else a more conservative approach by pulling the asserts. I'm not sure if asserts are compiled out in production builds in this code base?