Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hs.network.ping to always call didFinish callback #3531

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix hs.network.ping to always call didFinish callback #3531

merged 1 commit into from
Dec 10, 2023

Conversation

earwin
Copy link
Contributor

@earwin earwin commented Sep 2, 2023

See #3530 for details.

@earwin
Fix hs.network.ping to always call didFinish callback Hammerspoon#3530
fa7356c 
Right now, if the last ping packet send fails, `didFinish` is never invoked.
github-actions[bot]
github-actions bot requested changes Sep 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@earwin earwin mentioned this pull request Sep 3, 2023
Closed
@cmsj cmsj merged commit 9345f83 into Hammerspoon:master Dec 10, 2023
@cmsj cmsj added the pr-fix Pull Request implementing a bug fix label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@earwin @cmsj