Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging updates to LuaSkin #1457

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Conversation

asmagill
Copy link
Member

  • makes run-of-the-mill logs from hs.socket less obtrusive
  • remove –logAtLevel:withMessage:fromStackPos:

Basically prep work for #1426 and #1425; more to come, not ready for merge yet.

@asmagill
Copy link
Member Author

This does clean up the unnecessary log display for hs.socket (moves connection success, etc. to a lower level), and removes an unnecessary method from LuaSkin, so I believe it should be added per #1433, even though the additional log changes haven't been made yet... Objections?

@asmagill asmagill merged commit 1aed38f into Hammerspoon:master Aug 23, 2017
@asmagill asmagill deleted the loggingUpdates branch September 15, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant