Check an important security function return value in hs.httpserver's …

…certificate generator
Hammerspoon · Sep 27, 2016 · 39aa589 · 39aa589
1 parent 7a7b50b
commit 39aa589
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/extensions/httpserver/MYAnonymousIdentity.m b/extensions/httpserver/MYAnonymousIdentity.m
@@ -133,7 +133,10 @@ static BOOL generateRSAKeyPair(int sizeInBits,
     uint8_t* buf = data.mutableBytes;
 
     // Write the serial number:
-    SecRandomCopyBytes(kSecRandomDefault, kSerialLength, &buf[kSerialOffset]);
+    if (SecRandomCopyBytes(kSecRandomDefault, kSerialLength, &buf[kSerialOffset]) != 0) {
+        NSLog(@"SecRandomCopyBytes() failed");
+        return nil;
+    }
     buf[kSerialOffset] &= 0x7F; // non-negative
 
     // Write the issue and expiration dates: