Fix query replacement for non-spaced queries #272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When querying a single word (without spaces), the substitution string
${query}
won't be replaced.Explanation/Fix
string.gsub
returns two values: the string with substitutions and the number of substitutions madeIf doing the nested
gsub
, these two return values will be passed into the outergsub
, which accepts an optional fourth parameter specifying how many substitutions should be made. So the number of substitutions in the innergsub
determines the number of substitutions in the outergsub
: When the query doesn't contain a blank, that number of substitutions in the innergsub
is0
and the outergsub
won't replace anything, leaving${query}
in theurl
.By first assigning the
gsub
result to a variable, the number of substitutions return value will be ignored.