Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for docker github workflow #251

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Conversation

ewainberg
Copy link
Collaborator

@ewainberg ewainberg commented Feb 19, 2025

Adds a check for the docker container inside github workflow

Comment on lines +54 to +61
rr.set_cookie(
key="token",
value=bearer,
httponly=True,
samesite="lax",
secure=False,
max_age=max_age,
)

Check warning

Code scanning / CodeQL

Failure to use secure cookies Medium

Cookie is added without the Secure attribute properly set.
@ewainberg ewainberg force-pushed the issue/184-fix-docker-workflow branch 2 times, most recently from 3792b7b to 9e60cb9 Compare February 19, 2025 02:23
@ewainberg ewainberg force-pushed the issue/184-fix-docker-workflow branch from 9e60cb9 to 3892f38 Compare February 19, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants