fix the ops issue when integrate vllm hpu extension to TGI #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang, Yi A <[email protected]>
Signed-off-by: Wang, Yi A <[email protected]>
Signed-off-by: Wang, Yi A <[email protected]>
Signed-off-by: Wang, Yi A <[email protected]>
sywangyi
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz,
tzielinski-habana and
afierka-intel
as code owners
|
Hi, I'd like to integrate ops level optimization like flat-pa/MOE to TGI. I found some issue during integration, so I give a fix. please help review and merge. Thanks ! MOE is founding during the enabling of https://huggingface.co/microsoft/Phi-3.5-MoE-instruct |
|
fix in pipelined_pa is found in TGI benchmark where only block 0 is used |
Signed-off-by: Wang, Yi A <[email protected]>
Signed-off-by: Wang, Yi A <[email protected]>
mswiniarsk
reviewed
Apr 18, 2025
Signed-off-by: Wang, Yi A <[email protected]>
fmt and remove unused logger
|
@mswiniarsk done for the review comment |
michalkuligowski
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.