Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-218309] Updated Tests Workflow To Support Forked PR's #930

Merged
merged 3 commits into from
Mar 24, 2025
Merged

[SW-218309] Updated Tests Workflow To Support Forked PR's #930

merged 3 commits into from
Mar 24, 2025

Conversation

RonBenMosheHabana
Copy link
Collaborator

@RonBenMosheHabana RonBenMosheHabana commented Mar 19, 2025 •
edited by github-actions bot
Loading

Changes:

  • Changed the trigger of the tests from pull_request to issue_comment. now tests will be triggered only if a CODEOWNER will comment on the PR /run-gaudi-tests
  • Add random string to hlctl container when running the tests. I noticed that a lot of times in case of re-runs , tests is failing due to the error of workload already exists. the random string will solve it
  • Added a job that will collect all tests status and will fail/pass based on the tests execution status. It will be used as a mandatory status check in order to merge a PR(means that without all tests passed, a PR cannot be merged)

@michalkuligowski
Copy link

/run-gaudi-tests

@RonBenMosheHabana RonBenMosheHabana merged commit da46fc1 into habana_main Mar 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkuligowski michalkuligowski michalkuligowski approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@madamczykhabana madamczykhabana Awaiting requested review from madamczykhabana madamczykhabana is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz mgawarkiewicz is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonBenMosheHabana @michalkuligowski